Repository navigation
[FiveThirtyEight.com] Fix redirect loop (#13873) - #13875
Conversation
|
It looks like the redirect loop only happens for the root URL of Also, https://www.fivethirtyeight.com seems to redirect successfully to https://fivethirtyeight.com . So, the only change needed is to add an <target host="fivethirtyeight.com" />
<exclusion pattern="http://fivethirtyeight\.com/$" />
<test url="http://fivethirtyeight.com/politics/" />
<target host="www.fivethirtyeight.com" />
<target host="projects.fivethirtyeight.com" /> |
|
We also don't need the wildcard DNS comment, or at least I'm not sure why we need it. |
I am not entirely sure. J0WI usually asks for this comment. I think the main point is to warn that |
|
I wouldn't add either the wildcard DNS comment or |
|
I tend to add such comments to avoid a infinite list of (non) working targets that makes no sense. (e.g. common typos like |
|
@J0WI That makes sense, but the comment "Wildcard DNS" is not clear in itself, like if you took a random person and had them look at a random ruleset with that in it, if they would know what it means for the ruleset. I personally favor web/Google searches over Sublist3r, because Sublist3r finds a lot of these nonsense domains like you said. |
fix #13873