Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[FiveThirtyEight.com] Fix redirect loop (#13873) - #13875

Merged
jeremyn merged 4 commits into
EFForg:masterfrom
Bisaloo:538
Dec 4, 2017
Merged

jeremyn merged 4 commits into
EFForg:masterfrom
Bisaloo:538

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Dec 4, 2017 •

Copy link
Copy Markdown
Collaborator

fix #13873

@Bisaloo Bisaloo changed the title [FiveThirtyEight.com] Fix redirect loop (#13879) [FiveThirtyEight.com] Fix redirect loop (#13873) Dec 4, 2017
@jeremyn

jeremyn commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

It looks like the redirect loop only happens for the root URL of ^. For example, https://fivethirtyeight.com/politics/ seems fine.

Also, https://www.fivethirtyeight.com seems to redirect successfully to https://fivethirtyeight.com .

So, the only change needed is to add an exclusion for the root URL for ^, and an extra test, like this:

	<target host="fivethirtyeight.com" />
		<exclusion pattern="http://fivethirtyeight\.com/$" />
		<test url="http://fivethirtyeight.com/politics/" />
	<target host="www.fivethirtyeight.com" />
	<target host="projects.fivethirtyeight.com" />

@jeremyn

jeremyn commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

We also don't need the wildcard DNS comment, or at least I'm not sure why we need it.

@jeremyn jeremyn self-assigned this Dec 4, 2017
@Bisaloo

Bisaloo commented Dec 4, 2017

Copy link
Copy Markdown
Collaborator Author

We also don't need the wildcard DNS comment, or at least I'm not sure why we need it.

I am not entirely sure. J0WI usually asks for this comment. I think the main point is to warn that Sublist3r should not be trusted for this domain.

@jeremyn

jeremyn commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

I wouldn't add either the wildcard DNS comment or (partial) to the ruleset name. Since we didn't start with those, can you please remove them? Otherwise this looks fine to me.

@jeremyn
jeremyn merged commit ccfaae8 into EFForg:master Dec 4, 2017
@jeremyn

jeremyn commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

@Bisaloo Thanks, merged.

@J0WI FYI the above discussion since you were mentioned but not tagged.

@jeremyn jeremyn removed their assignment Dec 4, 2017
@J0WI

J0WI commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

I tend to add such comments to avoid a infinite list of (non) working targets that makes no sense. (e.g. common typos like ww., wwww.etc.)

@Bisaloo
Bisaloo deleted the 538 branch December 8, 2017 20:20
@jeremyn

jeremyn commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

@J0WI That makes sense, but the comment "Wildcard DNS" is not clear in itself, like if you took a random person and had them look at a random ruleset with that in it, if they would know what it means for the ruleset.

I personally favor web/Google searches over Sublist3r, because Sublist3r finds a lot of these nonsense domains like you said.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken redirect for fivethirtyeight.com

3 participants